Skip to content

Minor: Fix broken links for meetups in content library #13445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 15, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

@jonahgao noticed a bug in the translation of the content library added in

https://github.com/apache/datafusion/pull/13335/files#r1841468603:

This event seems incomplete and lacks links.

What changes are included in this PR?

Fix the missing links

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2024
Comment on lines 140 to 141
- **2024-06-25** [San Francisco Bay Area Apache DataFusion Meetup](https://lu.ma/6bphole2). [slides](https://docs.google.com/presentation/d/1Oz2yGllrWBkNGyiRMLr8qXTt4vmvtJWuI_weGThaZak/edit#slide=id.g26bebde4fcc_3_7)
- **2024-03-27** [Austin Apache DataFusion Meetup](https://github.com/apache/datafusion/discussions/8522). [slides](https://docs.google.com/presentation/d/1S51TK8waxHEJaxi_-uiSMrgQZ09m_hfaasPk5X5ExEY), [recording](https://www.youtube.com/watch?v=q1N3pH3tFw8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these two lines are duplicates of the previous ones.
CleanShot 2024-11-16 at 20 25 06@2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 -- that is what I get for rushing. Sorry about that. Fixed now

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alamb
Copy link
Contributor Author

alamb commented Nov 19, 2024

Looks good to me!

Thank you and sorry for the multiple mistakes on this one

@alamb alamb merged commit 398d5f6 into apache:main Nov 19, 2024
5 checks passed
@alamb alamb deleted the alamb/fix_content_lib branch November 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants