Test for string / numeric coercion #13606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Dec 2, 2024
| # -------------------------------------- | ||
|
|
||
| query BB | ||
| select ascii_1 = 1 as col1, ascii_1 = 1 as col2 from test_basic_operator; |
There was a problem hiding this comment.
why is ascii_1 = 1 projected twice?
(same for ascii_1 <> 1 case below)
There was a problem hiding this comment.
it was a mistake -- I meant to do the comparison the other way
|
fyi apache/arrow-rs#6714 was resolved recently. |
Awesome -- thank you I have it on my list to double check if we need any additional work (like timestamp --> Utf8View) I just haven't found the time yet to write the corresponding tests to verify in DataFusion. Hoping to be able to do so this week |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Utf8Viewinnumeric_string_coercion#13366Rationale for this change
While testing #13366 I found there are still some gaps with StringView:
What changes are included in this PR?
Add tests for string coercsion to integer. They currently fail as arrow-rs doesn't suport int --> StringView casting at the moment
Are these changes tested?
Are there any user-facing changes?