Always install correct version of rust in CI #14992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
alamb
commented
Mar 3, 2025
| @@ -17,14 +17,13 @@ | |||
|
|
|||
| name: Prepare Rust Builder | |||
| description: 'Prepare Rust Build Environment' | |||
| inputs: | |||
There was a problem hiding this comment.
This was only ever called with stable so the parameter is unecessary
alamb
commented
Mar 3, 2025
| "${RETRY[@]}" rustup default ${{ inputs.rust-version }} | ||
| echo "Installing Rust ..." | ||
| # install toolchain specified by rust-toolchain.toml | ||
| "${RETRY[@]}" rustup toolchain install |
There was a problem hiding this comment.
now this installs the version of rust specified by rust-toolchain.toml
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
We need to checkout the code in the builder setup to get the rust-toolchain.toml file
alamb
changed the title
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO remove the unused parameter to setup builder sript
Which issue does this PR close?
rustupchanges #14990Rationale for this change
We now use the rust-toolchain.toml file to specify what version of rust to use
However, the recently released
rustupversion no longer automatically installs this toolchainhttps://github.com/rust-lang/rustup/blob/f00c3d1fbcbe8d3ae2411e63ca906bc9b69e43d1/CHANGELOG.md?plain=1#L9-L17
Thus to ensure we have the correct toolchain installed, we need to run
rustup toolchain installWhat changes are included in this PR?
rustup toolchain installas part of the builder setupAre these changes tested?
By CI
Are there any user-facing changes?