Do not double alias Exprs #15008
Closed
Do not double alias Exprs #15008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
This was referenced Mar 4, 2025
Merged
|
Let's go with @blaginin 's version here: |
phillipleblanc
added a commit
to spiceai/datafusion
that referenced
this pull request
May 7, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895
sgrebnov
pushed a commit
to spiceai/datafusion
that referenced
this pull request
May 22, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895 # Conflicts: # datafusion/expr/src/expr.rs
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
May 24, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
May 24, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
May 26, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895 Do not double alias Exprs
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
May 26, 2025
UPSTREAM NOTE: This was attempted to be fixed with apache#15008 but was closed This is the tracking issue on DataFusion: apache#14895 Do not double alias Exprs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Nested
Expr::Aliasis confusing for display and for dealing with codeWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?