Add tests for simplification and coercion of SessionContext::create_physical_expr
#15034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 5, 2025
| create_expr_test(col("i").eq(lit("202410")), "CAST(i@1 AS Utf8) = 202410"); | ||
| create_expr_test(lit("202410").eq(col("i")), "202410 = CAST(i@1 AS Utf8)"); | ||
| // however, when simplified the casts on i should removed | ||
| create_simplified_expr_test(col("i").eq(lit("202410")), "CAST(i@1 AS Utf8) = 202410"); |
There was a problem hiding this comment.
This line should change when #14944 is resolved
alamb
force-pushed
the
alamb/test_coercion_projection
branch
from
7db17a4 to
30f73a4
Compare
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SessionContext::create_physical_exprdoes not unwrap casts (and thus is not always optimal) #14987Rationale for this change
We are trying to make predicates like `int_col = '1234' faster in delta.rs. Let's add a test showing what is going on
What changes are included in this PR?
Add tests for #14987
Are these changes tested?
yes
Are there any user-facing changes?