fix: date_trunc bench broken by #15049 #15169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @Omega359 |
alamb
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thank you @Blizzara and @Omega359
I ran this locally and it worklooks good now:
Running benches/date_trunc.rs (target/release/deps/date_trunc-501285eb70a1c788)
Gnuplot not found, using plotters backend
date_trunc_minute_1000 time: [18.116 µs 18.217 µs 18.304 µs]
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Got broken in #15049, as the call for return_type was only providing one data type instead of two.
What changes are included in this PR?
Are these changes tested?
cargo bench --bench date_truncruns sucessfully after thisAre there any user-facing changes?