Add "end to end parquet reading test" for WASM #15362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 23, 2025
| @@ -185,26 +206,56 @@ mod test { | |||
|
|
|||
| #[wasm_bindgen_test(unsupported = tokio::test)] | |||
| async fn test_parquet_write() { | |||
There was a problem hiding this comment.
It seems to me that this test is now redundant with "test_read_and_write" but looks good to me
| let url = Url::parse("memory://").unwrap(); | ||
| session_ctx.register_object_store(&url, Arc::new(store)); | ||
|
|
||
| let df = session_ctx |
|
LGTM this is really nice, thank you @jsai28 |
|
Thanks again @jsai28 and @XiangpengHao |
qstommyshu
pushed a commit
to qstommyshu/datafusion
that referenced
this pull request
Mar 27, 2025
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
End to end parquet reading test for WASM.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No