Attach diagnostic for wrong arg number error #15451
Draft
+342
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
Chen-Yuan-Lai
force-pushed
the
attach_Diagnostic_for_wrong_arg_number_error
branch
from
bbb8be4 to
cd7d998
Compare
Chen-Yuan-Lai
force-pushed
the
attach_Diagnostic_for_wrong_arg_number_error
branch
from
33be555 to
edcb2a9
Compare
…ailed diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Diagnosticto "wrong number of arguments" error #14432 .Rationale for this change
well explained in the issue.
What changes are included in this PR?
take_function_args_with_diag, which can accept span info and rerunDataFusionError::Diagnostic.Are these changes tested?
Are there any user-facing changes?