Skip to content

Improve spill performance: Disable re-validation of spilled files #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 5, 2025
Merged

Improve spill performance: Disable re-validation of spilled files #15454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
06fcb5e
add skip_validation and comment
zebsme Mar 27, 2025
46f967e
add benchmark
zebsme Mar 27, 2025
b9226fb
fmt
zebsme Mar 27, 2025
ca20b79
update sqllogictests and fmt Cargo.toml
zebsme Mar 27, 2025
8e02b9f
use SpillManager in benchmark
zebsme Mar 28, 2025
3ac770e
fix clippy
zebsme Mar 28, 2025
0c52e80
upgrade dependencies
Mar 31, 2025
5a30981
Update comment
zebsme Apr 1, 2025
112f71b
Merge remote-tracking branch 'apache/main' into issue-15320
alamb Apr 1, 2025
cfe0e10
Merge remote-tracking branch 'apache/main' into issue-15320
alamb Apr 2, 2025
d1f2f80
Merge remote-tracking branch 'apache/main' into issue-15320
alamb Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 44 additions & 36 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ ahash = { version = "0.8", default-features = false, features = [
"runtime-rng",
] }
apache-avro = { version = "0.17", default-features = false }
arrow = { version = "54.2.1", features = [
arrow = { version = "54.3.0", features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other arrow dependencies need to be upgraded as well (this is automatically done by cargo already, but makes sense to update it in this file as well).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree -- we need to specify 54.3.0 as we are now using a feature from 54.3.0

and I think we should do all the other crates too as @Dandandan suggests

"prettyprint",
"chrono-tz",
] }
arrow-buffer = { version = "54.1.0", default-features = false }
arrow-flight = { version = "54.2.1", features = [
arrow-buffer = { version = "54.3.0", default-features = false }
arrow-flight = { version = "54.3.0", features = [
"flight-sql-experimental",
] }
arrow-ipc = { version = "54.2.0", default-features = false, features = [
arrow-ipc = { version = "54.3.0", default-features = false, features = [
"lz4",
] }
arrow-ord = { version = "54.1.0", default-features = false }
arrow-schema = { version = "54.1.0", default-features = false }
arrow-ord = { version = "54.3.0", default-features = false }
arrow-schema = { version = "54.3.0", default-features = false }
async-trait = "0.1.88"
bigdecimal = "0.4.7"
bytes = "1.10"
Expand Down Expand Up @@ -149,7 +149,7 @@ itertools = "0.14"
log = "^0.4"
object_store = { version = "0.11.0", default-features = false }
parking_lot = "0.12"
parquet = { version = "54.2.1", default-features = false, features = [
parquet = { version = "54.3.0", default-features = false, features = [
"arrow",
"async",
"object_store",
Expand Down
5 changes: 5 additions & 0 deletions datafusion/physical-plan/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ insta = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
rstest_reuse = "0.7.0"
tempfile = "3.19.1"
tokio = { workspace = true, features = [
"rt-multi-thread",
"fs",
Expand All @@ -81,3 +82,7 @@ tokio = { workspace = true, features = [
[[bench]]
harness = false
name = "partial_ordering"

[[bench]]
harness = false
name = "spill_io"
Loading
Loading