fix: normalize window ident #15639
Merged
fix: normalize window ident #15639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Apr 9, 2025
|
|
||
| // If there are any multiple-defined windows, we raise an error. | ||
| fn check_conflicting_windows(window_defs: &[NamedWindowDefinition]) -> Result<()> { | ||
| for (i, window_def_i) in window_defs.iter().enumerate() { |
There was a problem hiding this comment.
is this method for identifying duplicate named windows? if so probably we can simplify this a little bit like
let mut seen = HashSet::new();
for (name, _) in window_defs {
if !seen.insert(name) {
return plan_err!("The window {} is defined multiple times!", name);
}
}
There was a problem hiding this comment.
I haven't modified this method, It was there before I changed this file. I think your suggestion make sense, but maybe we can change it in another PR.
comphead
reviewed
Apr 9, 2025
datafusion/sql/src/select.rs
Outdated
| return ControlFlow::Break(()); | ||
| // All named windows must be defined with a WindowSpec. | ||
| if let Some(WindowType::NamedWindow(ident)) = &f.over { | ||
| err = Some(DataFusionError::Plan(format!( |
There was a problem hiding this comment.
@chenkovsky can you make a favor and change this to plan_err!?
comphead
reviewed
Apr 9, 2025
| 4 11 | ||
| 5 16 | ||
|
|
||
| # window definitions with aliases |
There was a problem hiding this comment.
is it the same test as above? 🤔
There was a problem hiding this comment.
the difference is lower case & upper case.
comphead
approved these changes
Apr 9, 2025
|
Thanks @chenkovsky and @comphead |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* fix: normalize window name * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ident normalizer is not called.
What changes are included in this PR?
normalize ident before comparing window name.
Are these changes tested?
UT
Are there any user-facing changes?
NO