Implement min max for dictionary types #15827
Open
+47
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangpengHao
commented
Apr 23, 2025
| @@ -1854,9 +1866,31 @@ mod tests { | |||
| #[test] | |||
| fn test_get_min_max_return_type_coerce_dictionary() -> Result<()> { | |||
| let data_type = | |||
| DataType::Dictionary(Box::new(DataType::Utf8), Box::new(DataType::Int32)); | |||
| DataType::Dictionary(Box::new(DataType::Int32), Box::new(DataType::Utf8)); | |||
There was a problem hiding this comment.
I don't think Dict<Utf8, Int32> is a valid dictionary type, so I swapped the key and value. Maybe we should do something to only allow ArrowDictionaryKeyType as the key type, but it's not obvious how to enforce it with the current enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I hit a run time error when passing a dictionary type to the min/max aggregation.
What changes are included in this PR?
This PR handles min/max for dictionary types.
Are these changes tested?
Yes
Are there any user-facing changes?