Skip to content

infer placeholder datatype for IN lists #15864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

kczimm
Copy link
Contributor

@kczimm kczimm commented Apr 26, 2025

Which issue does this PR close?

Rationale for this change

Placeholders are currently limited to certain expressions.

What changes are included in this PR?

This PR addes placeholder inference in the following additional expressions:

  • Expr::InList
  • Expr::Like
  • Expr::SimilarTo

Are these changes tested?

Yes

Are there any user-facing changes?

Yes, placeholders are supported in additional expressions.

Copy link
Contributor

@phillipleblanc phillipleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kczimm!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @kczimm and @phillipleblanc

@alamb alamb merged commit af99b54 into apache:main Apr 30, 2025
1 check passed
@phillipleblanc phillipleblanc deleted the kczimm/infer-placeholder-in-clause branch April 30, 2025 13:25
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
* infer placeholder datatype for IN lists

* infer placeholder datatype for Expr::Like

* add tests for Expr::SimilarTo

---------

Co-authored-by: Kevin <[email protected].>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholders in IN lists are not inferred
3 participants