feat: rewrite subquery into dependent join logical plan #16016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
duongcongtoai
changed the title
|
FYI @irenjj |
support sort support agg dummy unnest update test
irenjj
approved these changes
Jun 7, 2025
| // column | ||
| let alias = match e { | ||
| Expr::InSubquery(_) | Expr::Exists(_) | Expr::ScalarSubquery(_) => { | ||
| subquery_alias_by_offset.get(offset_ref).unwrap() |
There was a problem hiding this comment.
nit: unwrap() is not allowed
There was a problem hiding this comment.
resolved, convert into error in case of unwrap fail
irenjj
reviewed
Jun 7, 2025
Comment on lines
151
to
162
| fn rewrite_projection( | ||
| &mut self, | ||
| original_proj: &Projection, | ||
| dependent_join_node: &Node, | ||
| current_subquery_depth: usize, | ||
| mut current_plan: LogicalPlanBuilder, | ||
| subquery_alias_by_offset: HashMap<usize, String>, | ||
| ) -> Result<LogicalPlanBuilder> { | ||
| // everytime we meet a subquery during traversal, we increment this by 1 | ||
| // we can use this offset to lookup the original subquery info | ||
| // in subquery_alias_by_offset | ||
| // the reason why we cannot create a hashmap keyed by Subquery object HashMap<Subquery,String> |
There was a problem hiding this comment.
Maybe the shared parts among rewrite_* functions can be extracted
There was a problem hiding this comment.
refactored, so far i can see filter, projection and agg can be rewritten using one shared function
fix subquery in join filter
…query-in-join-filter chore: more constraint on correlated subquery in join filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR is a part of a long story for a general purpose subquery decorrelation, after some discussion in #5492, this PR proposes adding the followings:
To avoid breaking existing tests and smoother collaboration, the changes should happen in the following sequence
1. Merge item 1 without integrate the new optimizor to the main flow (behavior is tested in-code instead of sqllogictests)
2. Start implement more rewriting rules for different query plan (aggregate, projection, filter ...) using the a new optimizer
We keep the working of this new optimizor in a working branch, and if the implementation can fully support existing subqueries,
we make the following change to the main branch
From
Into
Or we can even combine the 2 optimizors into one, into
The following works are needed after merging this PR
Rationale for this change
Are these changes tested?
Are there any user-facing changes?