Skip to content

Semver-checks for all crate on merge and push #16078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

logan-keede
Copy link
Contributor

@logan-keede logan-keede commented May 18, 2025

Which issue does this PR close?

Rationale for this change

Detect accidental breaking changes.

What changes are included in this PR?

A github workflow, that uses cargo semver-checks for all crates. divided into three parts because 1 job goes on for too long + crashes before completion(can probably be fixed by emptying/deleting cache in the middle.)

Are these changes tested?

On local branch by CI.

Are there any user-facing changes?

NO.

@github-actions github-actions bot added the development-process Related to development process of DataFusion label May 18, 2025
@logan-keede
Copy link
Contributor Author

cargo semver-checks is probably too heavy to run on every push but I have kept it for testing purpose.
I would also like to know other contributor/committer`s opinion.

@logan-keede logan-keede changed the title Semver-checks for all crate on merge and PR Semver-checks for all crate on merge and push May 18, 2025
@logan-keede logan-keede marked this pull request as ready for review May 19, 2025 12:08
@logan-keede
Copy link
Contributor Author

cc @crepererum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI check for cargo-semver-checks Use cargo semver-checks for release testing
1 participant