Skip to content

Improved experience when remote object store URL does not end in / #16386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiedeyantu
Copy link
Member

@xiedeyantu xiedeyantu commented Jun 12, 2025

Which issue does this PR close?

Rationale for this change

It would be automatically add a / to the path if the first one was not found and try again.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the datasource Changes to the datasource crate label Jun 12, 2025
@xiedeyantu
Copy link
Member Author

@alamb Could you help reivew this PR?

@alamb
Copy link
Contributor

alamb commented Jun 16, 2025

@alamb Could you help reivew this PR?

Thanks @xiedeyantu ! We normally need to add tests as part of any code PR -- could you look into adding some tests and documentation about how this change works?

@xiedeyantu
Copy link
Member Author

xiedeyantu commented Jun 16, 2025

@alamb Could you help reivew this PR?

Thanks @xiedeyantu ! We normally need to add tests as part of any code PR -- could you look into adding some tests and documentation about how this change works?

@alamb Is there any example I can refer to for testing involving s3, because real access requires ak/sk and the real path?

@alamb
Copy link
Contributor

alamb commented Jun 17, 2025

@alamb Could you help reivew this PR?

Thanks @xiedeyantu ! We normally need to add tests as part of any code PR -- could you look into adding some tests and documentation about how this change works?

@alamb Is there any example I can refer to for testing involving s3, because real access requires ak/sk and the real path?

I think you can follow the one here: https://datafusion.apache.org/user-guide/cli/datasources.html#s3

To read from a public S3 bucket without signatures, use the aws.SKIP_SIGNATURE option:

CREATE EXTERNAL TABLE nyc_taxi_rides
STORED AS PARQUET LOCATION 's3://altinity-clickhouse-data/nyc_taxi_rides/data/tripdata_parquet/'
OPTIONS(aws.SKIP_SIGNATURE true);

@alamb
Copy link
Contributor

alamb commented Jun 17, 2025

@blaginin also did an end to end test with S3 in the CI tests. The instructions are here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource Changes to the datasource crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved experience when remote object store URL does not end in /
2 participants