-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add more components to the wasm-pack compatible list #8843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ authors = { workspace = true } | |
rust-version = "1.70" | ||
|
||
[lib] | ||
crate-type = ["cdylib", "rlib",] | ||
crate-type = ["cdylib", "rlib"] | ||
|
||
[dependencies] | ||
|
||
|
@@ -37,11 +37,14 @@ crate-type = ["cdylib", "rlib",] | |
# all the `std::fmt` and `std::panicking` infrastructure, so isn't great for | ||
# code size when deploying. | ||
console_error_panic_hook = { version = "0.1.1", optional = true } | ||
datafusion = { path = "../core", default-features = false } | ||
|
||
datafusion-common = { workspace = true } | ||
datafusion-execution = { workspace = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I double checked and this addition means that the wasm ci job now checks these crates Here is the example CI run from this PR showing the new crates building in wasm https://github.com/apache/arrow-datafusion/actions/runs/7504130188/job/20430447784?pr=8843#step:6:194 |
||
datafusion-expr = { workspace = true } | ||
datafusion-optimizer = { workspace = true } | ||
datafusion-physical-expr = { workspace = true } | ||
datafusion-physical-plan = { workspace = true } | ||
datafusion-sql = { workspace = true } | ||
|
||
# getrandom must be compiled with js feature | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move this to dev-dependencies casually. But
datafusion-substrait
anddatafusion-proto
are not supported yet.