Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dubbo plugin useless dependency #15236

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change?

Remove dubbo-test in dubbo-plugin

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (d3b1e1f) to head (630f284).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15236      +/-   ##
============================================
- Coverage     60.79%   60.78%   -0.01%     
+ Complexity    10892    10886       -6     
============================================
  Files          1885     1885              
  Lines         86082    86082              
  Branches      12895    12895              
============================================
- Hits          52331    52328       -3     
- Misses        28303    28309       +6     
+ Partials       5448     5445       -3     
Flag Coverage Δ
integration-tests 33.13% <ø> (-0.02%) ⬇️
samples-tests 29.19% <ø> (-0.01%) ⬇️
unit-tests 58.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxsean
Copy link
Contributor

oxsean commented Mar 14, 2025

Why remove it? is the SPI file shade check provider by this? If so, I don't think it can be removed

@Stellar1999
Copy link
Contributor Author

Why remove it? is the SPI file shade check provider by this? If so, I don't think it can be removed

No, I just removed dubbo-test-check. It's for integration testing. This is part of the removal of the dubbo-test module.

@Stellar1999
Copy link
Contributor Author

link #15301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants