Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early decode x509 certificate when connection established #15259

Open
wants to merge 1 commit into
base: 3.2
Choose a base branch
from

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change?

  • Certificate in SSLSession is javax.security.cert.X509Certificate and cannot load properties like SANs
  • Only java.security.cert.X509Certificate support get custom properties
  • Try load org.apache.dubbo.common.ssl.DubboX509Certificate when connection established

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 41.36%. Comparing base (2268c29) to head (6c1596a).

Files with missing lines Patch % Lines
.../apache/dubbo/common/ssl/DubboX509Certificate.java 0.00% 49 Missing ⚠️
...port/netty4/NettyPortUnificationServerHandler.java 0.00% 9 Missing ⚠️
...ting/transport/netty4/ssl/SslClientTlsHandler.java 0.00% 9 Missing ⚠️
...ting/transport/netty4/ssl/SslServerTlsHandler.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #15259      +/-   ##
============================================
- Coverage     41.39%   41.36%   -0.04%     
+ Complexity    10513    10512       -1     
============================================
  Files          1652     1653       +1     
  Lines         71438    71514      +76     
  Branches      10159    10162       +3     
============================================
+ Hits          29573    29581       +8     
- Misses        37731    37793      +62     
- Partials       4134     4140       +6     
Flag Coverage Δ
integration-tests 38.36% <0.00%> (-0.03%) ⬇️
samples-tests 36.34% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants