Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize scheduled register #15278

Open
wants to merge 6 commits into
base: 3.3
Choose a base branch
from

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change?

Due to the early update of the revision, scheduled tasks will no longer call doUpdate retry after reporting metadata or registration failure.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.82%. Comparing base (c778473) to head (de1728b).

Current head de1728b differs from pull request most recent head 85856c2

Please upload reports for the commit 85856c2 to get more accurate results.

Files with missing lines Patch % Lines
...ubbo/registry/client/AbstractServiceDiscovery.java 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c778473) and HEAD (de1728b). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c778473) HEAD (de1728b)
samples-tests 1 0
unit-tests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##                3.3   #15278       +/-   ##
=============================================
- Coverage     60.77%   32.82%   -27.95%     
+ Complexity    10920    10036      -884     
=============================================
  Files          1886     1885        -1     
  Lines         86122    86088       -34     
  Branches      12902    12896        -6     
=============================================
- Hits          52337    28258    -24079     
- Misses        28331    53664    +25333     
+ Partials       5454     4166     -1288     
Flag Coverage Δ
integration-tests 32.82% <0.00%> (-0.38%) ⬇️
samples-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants