Skip to content

fix potential Netty IO blocking in TripleProtocol connection handling… #15283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 3.3
Choose a base branch
from

Conversation

ankitshokeen
Copy link

#13041

What is the purpose of the change?

This PR fixes Netty IO blocking in TripleProtocol's NettyConnectionClient to prevent client-side request timeouts and improve stability when using the triple protocol.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.59%. Comparing base (731612b) to head (065a0dc).

Files with missing lines Patch % Lines
...moting/transport/netty4/NettyConnectionClient.java 40.00% 8 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (731612b) and HEAD (065a0dc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (731612b) HEAD (065a0dc)
unit-tests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##                3.3   #15283       +/-   ##
=============================================
- Coverage     60.75%   35.59%   -25.17%     
+ Complexity    10917    10859       -58     
=============================================
  Files          1886     1886               
  Lines         86097    86112       +15     
  Branches      12896    12896               
=============================================
- Hits          52310    30653    -21657     
- Misses        28333    50981    +22648     
+ Partials       5454     4478      -976     
Flag Coverage Δ
integration-tests 33.00% <40.00%> (-0.20%) ⬇️
samples-tests 29.53% <40.00%> (+0.16%) ⬆️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankitshokeen
Copy link
Author

ankitshokeen commented Apr 13, 2025

Hi @iJIAJIA, @AlbumenJ, @JunJieLiu51520 could you please take a look and let me know if there are any further changes I should make? One of the CI tests is currently failing because it depends on a separate PR.
issue worked on #13041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants