fix: Fix the issue of HTTP calling 404 when the first letter of RPC #15292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method name in proto is capitalized (apache#15291)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15292 +/- ##
=========================================
Coverage 60.77% 60.77%
- Complexity 10920 10922 +2
=========================================
Files 1886 1886
Lines 86122 86127 +5
Branches 12902 12903 +1
=========================================
+ Hits 52337 52346 +9
+ Misses 28331 28323 -8
- Partials 5454 5458 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxsean
approved these changes
Apr 2, 2025
oxsean
requested changes
Apr 2, 2025
| @@ -130,6 +130,12 @@ public void register(Invoker<?> invoker) { | |||
| consumer.accept((methods) -> { | |||
| Method method = methods.get(0); | |||
| MethodDescriptor md = sd.getMethod(method.getName(), method.getParameterTypes()); | |||
| if (md == null) { | |||
| String originMethodName = method.getName(); | |||
| String upperMethod = | |||
There was a problem hiding this comment.
It's better to add a length check, otherwise the method will fail with only one letter
There was a problem hiding this comment.
- Add a method name length check is possible.
- After testing , when there is only one character, there will be no problem.
- I will consider resolving this issue by modifying the dubbo-compiler or DefaultRequestMappingRegistry, taking into account the comprehensive impact scope and conducting thorough testing
AlbumenJ
requested changes
Apr 7, 2025
| @@ -130,6 +130,12 @@ public void register(Invoker<?> invoker) { | |||
| consumer.accept((methods) -> { | |||
| Method method = methods.get(0); | |||
| MethodDescriptor md = sd.getMethod(method.getName(), method.getParameterTypes()); | |||
| if (md == null) { | |||
There was a problem hiding this comment.
Suggested change
| if (md == null) { | |
| if (md == null && md.getName().getLength()>1) { |
There was a problem hiding this comment.
- After testing , when there is only one character, there will be no problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method name in proto is capitalized (#15291)
What is the purpose of the change?
Fix the issue of HTTP calling 404 when the first letter of RPC method name in proto is capitalized （#15291)
Checklist