[hotfix] Simplify the calling on addShutdownHook #26363
Open
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Mar 27, 2025
| @@ -211,7 +211,7 @@ public static void main(String[] args) throws Exception { | |||
| if (callerHasHook) { | |||
| // Verifies the case that both FileChannelManager and its upper component | |||
| // have registered shutdown hooks, like in IOManager. | |||
| ShutdownHookUtil.addShutdownHook(() -> manager.close(), "Caller", LOG); | |||
| ShutdownHookUtil.addShutdownHook(manager, "Caller", LOG); | |||
There was a problem hiding this comment.
I don't think this test drives the changed code.
There was a problem hiding this comment.
I don't understand what you said. Could you tell me more?
There was a problem hiding this comment.
sorry. The changed code is in method
public IOManagerAsync(String[] tempDirs, ExecutorService executorService) {
super(tempDirs, executorService);
So to test this we need to drive this method. I think you have a test that tests the same pattern but not the actual changed code.
am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR proposes to simplify the calling on
addShutdownHook.Brief change log
Simplify the calling on
addShutdownHook.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation