[FLINK-37575] Simplify the code for creating Netty shuffle environment. #26368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to simplify the code for creating Netty shuffle environment.
Currently,
NettyShuffleServiceFactory.createNettyShuffleEnvironment
has a parameter 'String[] tmpDirPaths', but its true purpose is only to use its length.Even if developers want to use the value of
String [] tmpDirPaths
in the future, it's no problem due to the parameterNettyShuffleEnvironmentConfiguration config
ofNettyShuffleServiceFactory.createNettyShuffleEnvironment
has the fieldprivate final String[] tempDirs;
too. We can use it by calling thegetTempDirs
show below.This PR also unify the temp directory with
tempDirs
.Brief change log
Simplify the code for creating Netty shuffle environment.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation