[FLINK-37541][table-planner] Deprecate getTargetColumns in DynamicTableSink.Context

[xiangyuf]

What is the purpose of the change

Deprecate getTargetColumns in DynamicTableSink.Context.

See more in FLIP design https://cwiki.apache.org/confluence/display/FLINK/FLIP-506%3A+Support+Reuse+Multiple+Table+Sinks+in+Planner and discussion thread https://lists.apache.org/thread/r1wo9sf3d1725fhwzrttvv56k4rc782m

Brief change log

• Deprecate getTargetColumns in DynamicTableSink.Context

Verifying this change

This change is covered by tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? yes
• If yes, how is the feature documented? FLIP-506

[flinkbot]

CI report:

• 422fe25 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[davidradl]

This is no detail in the PR or Jira as to why you would like this method deprecated. Please could you add more detail as to why you would like this changed.

[davidradl]

is there a case to want to see the target columns but not write to them? In which case we could keep this method?

[xiangyuf]

This is no detail in the PR or Jira as to why you would like this method deprecated. Please could you add more detail as to why you would like this changed.

Hi @davidradl, the reason why I need to deprecate this method is documented in the FLIP design: https://cwiki.apache.org/confluence/display/FLINK/FLIP-506%3A+Support+Reuse+Multiple+Table+Sinks+in+Planner and discussion thread: https://lists.apache.org/thread/r1wo9sf3d1725fhwzrttvv56k4rc782m. In short, by deprecating target columns in context, we can safely reuse sinks even with different target columns if they haven't implemented the SupportsTargetColumnWriting interface.