[FLINK-37596][metrics] Close metric group of a finished split #26388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efrat19
commented
Apr 6, 2025
| @@ -103,7 +103,6 @@ public TestingSourceOperator( | |||
|
|
|||
| this.subtaskIndex = subtaskIndex; | |||
| this.parallelism = parallelism; | |||
| this.metrics = UnregisteredMetricGroups.createUnregisteredOperatorMetricGroup(); | |||
There was a problem hiding this comment.
Efrat19
force-pushed
the
FLINK-37596
branch
2 times, most recently
from
51c7469 to
b8c9dbb
Compare
pnowojski
approved these changes
Apr 7, 2025
...me/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceSplitMetricGroup.java
Outdated
Show resolved
Hide resolved
[FLINK-37596] Remove redundant metricGroup initialization
pnowojski
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the metric group of a finished split
Added a test to verify the group is closed and metrics are deregistered.
For the test setup I removed a redundant initialization of
org.apache.flink.streaming.api.operators.AbstractStreamOperator#metrics(since anUnregisteredMetricGroupis already passed to it via theorg.apache.flink.streaming.runtime.tasks.StreamMockEnvironment#taskMetricGroup)