Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37603] QueryOperation SQL Serialization customization #26389

Merged
merged 4 commits into from
Apr 10, 2025
Merged

[FLINK-37603] QueryOperation SQL Serialization customization #26389

merged 4 commits into from
Apr 10, 2025

Conversation

dawidwys
Copy link
Contributor

@dawidwys dawidwys commented Apr 2, 2025

What is the purpose of the change

Provide a way to customize SQL serialization of ResolvedExpressions

Verifying this change

Added a test in QueryOperationSqlSerializationTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 2, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dawidwys dawidwys force-pushed the flink37603 branch 6 times, most recently from afbc07a to d200f79 Compare April 4, 2025 09:48
twalthr
twalthr reviewed Apr 8, 2025
View reviewed changes
twalthr
twalthr reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @dawidwys. I added my last set of comment. Should be good in the next iteration.

@dawidwys dawidwys merged commit feb7ab1 into apache:master Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalthr twalthr

Assignees
No one assigned
Labels
component=TableSQL/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawidwys @flinkbot @twalthr