Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-2.0][FLINK-37458][datastream] Forbid enableAsyncState() for synchronous operators #26395

Open
wants to merge 1 commit into
base: release-2.0
Choose a base branch
from

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Apr 3, 2025

Backport #26283 to release-2.0

What is the purpose of the change

Throw an exception when enableAsyncState() for synchronous operators.

Brief change log

  • Override OneInputTransformation#enableAsyncState()

Verifying this change

  • JobGraphGeneratorTestBase#testEnableAsyncStateForSyncOperatorThrowException

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport, LGTM

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 3, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

(OneInputStreamOperator<IN, OUT>)
((SimpleOperatorFactory<OUT>) operatorFactory).getOperator();
if (!(operator instanceof AsyncStateProcessingOperator)) {
super.enableAsyncState();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious shouldn't this be an error?
As is the caller amkes this call anf would assume that async is enabled, but it is not.

@fredia
Copy link
Contributor Author

fredia commented Apr 7, 2025

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants