[hotfix] Rename loadJarFile to checkJarFile #26427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Apr 9, 2025
| @@ -440,7 +440,7 @@ private static String getEntryPointClassNameFromJar(URL jarFile) | |||
| } | |||
|
|
|||
| @Nullable | |||
| private static URL loadJarFile(File jar) throws ProgramInvocationException { | |||
| private static URL checkJarFile(File jar) throws ProgramInvocationException { | |||
There was a problem hiding this comment.
I see on line 453 an existing call to checkJarFile(jarFileUrl); So the method is now recursive, when before the fix it was not . Am I missing something?
There was a problem hiding this comment.
Yes, I know it. I think the overriding method is not a problem.
|
@flinkbot run azure |
beliefer
force-pushed
the
rename-loadJarFile
branch
from
3ae7123 to
69eb1a0
Compare
|
ping @tisonkun cc @1996fanrui @davidradl @GOODBOY008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to rename
loadJarFiletocheckJarFile.The reason is
loadJarFilejust checking if the jar file is valid and is not related to load.Brief change log
Rename
loadJarFiletocheckJarFile.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation