Skip to content

[FLINK-37649][datagen] Datagen connector cannot set length for collection type #26437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Apr 10, 2025

What is the purpose of the change

Fix the bug that datagen connector cannot set length for collection type.

Brief change log

  • Add lenOption to the legitimate set of options.

Verifying this change

Introduce a unit test case to cover this.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 10, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@davidradl
Copy link
Contributor

I wonder if we should add the test case mentioned in the Jira to the datagen docs as an example WDYT?

@reswqa
Copy link
Member Author

reswqa commented Apr 11, 2025

I wonder if we should add the test case mentioned in the Jira to the datagen docs as an example WDYT?

@davidradl The documentation indeed is not very friendly especially when it does not mention some of the supported features(e.g. fields.xxx.element/key/value.yyy for nested type). I'm inclined that we should rewrite/refactor it, but there's not much bandwidth for me at the moment . If you'd like to update it, I'd be happy to review :).

@davidradl
Copy link
Contributor

@reswqa thanks I can improve the docs. I have raised a Jira . Please could you assign me the Jira, thanks :-)

Copy link
Contributor

@codenohup codenohup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants