-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19421. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-aliyun. #7634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thank you @slfan1989 . The object store integration tests don't run as part of our CI, and I'm not set up to run these. If we can find someone to do a test run before merging this, that would be best.
@cnauroth Thank you for your suggestion! I'll try to find the person responsible for this module to help review this part of the code. |
@drankye We are trying to upgrade from JUnit 4 to JUnit 5 and need to modify the unit tests for the hadoop-aliyun module. Could you please review this PR? cc: @Hexiaoqiao |
🎊 +1 overall
This message was automatically generated. |
Description of PR
JIRA: HADOOP-19421. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-aliyun.
How was this patch tested?
mvn clean test & Junit test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?