[HUDI-9311] Revert HUDI-7146 which causes perf overhead for merging MDT log files #13136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
force-pushed
the
revert-HUDI-7147
branch
from
8083fdc to
050e59a
Compare
nsivabalan
changed the title
nsivabalan
changed the title
nsivabalan
changed the title
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieAvroHFileWriter.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieAvroHFileWriter.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java
Outdated
Show resolved
Hide resolved
...rce/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
Outdated
Show resolved
Hide resolved
nsivabalan
force-pushed
the
revert-HUDI-7147
branch
from
ae463dc to
0b967a1
Compare
|
@the-other-tim-brown : addressed the feedback |
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java
Outdated
Show resolved
Hide resolved
danny0405
reviewed
Apr 14, 2025
danny0405
reviewed
Apr 14, 2025
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
Outdated
Show resolved
Hide resolved
danny0405
reviewed
Apr 14, 2025
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java
Outdated
Show resolved
Hide resolved
nsivabalan
force-pushed
the
revert-HUDI-7147
branch
from
2b296ee to
6859109
Compare
|
@the-other-tim-brown @danny0405 : addressed all feedback |
danny0405
approved these changes
Apr 14, 2025
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
…DT log files (apache#13136) (cherry picked from commit d2ea523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
We added support for duplicate entries in hfile to support secondary index #10617 here. But after lot of brainstorming sessions, design of SI evolved and duplicate entries is not a requirement. So, reverting the patch to avoid the perf overhead for now. May be, if we end up adding a new MDT index which might require duplicate keys, we can bring it back w/o causing much perf overhead.
Impact
Fixes the perf regression with spark sql writes.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist