feat: Add rest catalog support for playground #1220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing left is the conflicts. |
liurenjie1024
changed the title
xxchan
reviewed
Apr 23, 2025
Comment on lines
+18
to
+37
| [[catalogs]] | ||
| name = "demo" | ||
| type = "rest" | ||
| uri = "http://localhost:8080" | ||
| warehouse = "s3://iceberg-demo" | ||
|
|
||
| [catalogs.props] | ||
| "s3.endpoint" = "http://localhost:9000" | ||
| "s3.access_key_id" = "admin" | ||
|
|
||
|
|
||
| [[catalogs]] | ||
| name = "demo2" | ||
| type = "rest" | ||
| uri = "http://localhost2:8080" | ||
| warehouse = "s3://iceberg-demo2" | ||
|
|
||
| [catalogs.props] | ||
| "s3.endpoint" = "http://localhost2:9090" | ||
| "s3.access_key_id" = "admin2" |
There was a problem hiding this comment.
Can we use a format like this:
i.e., put name in the table, instead using Array of tables. I think this can be more user-friendly.
The main reason is that [catalogs.props] is not very clear which catalog does it belong to.
[catalogs.demo]
type = "rest"
uri = "http://localhost:8080/"
warehouse = "s3://iceberg-demo"
[catalogs.demo.props]
"s3.endpoint" = "http://localhost:9000/"
"s3.access_key_id" = "admin"
[catalogs.demo2]
type = "rest"
uri = "http://localhost2:8080/"
warehouse = "s3://iceberg-demo2"
[catalogs.demo2.props]
"s3.endpoint" = "http://localhost2:9090/"
"s3.access_key_id" = "admin2"There was a problem hiding this comment.
Sounds good to me. I'm planning to close this pr and replace with catalog builder.
|
Close this pr to replace it with catalog builder api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Add support for rest catalog.
Are these changes tested?
UT.