Introduce scheduler for sqllogictests #1244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liurenjie1024 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a scheduler API for sqllogictests, refactoring engine abstractions and adding new scheduling functionality.
- Added a new scheduler module with a Schedule struct to run steps sequentially.
- Refactored the engine interface by replacing the previous Engine trait with an EngineRunner trait and updating the DataFusion engine accordingly.
- Updated Cargo.toml to include new dependencies.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/sqllogictest/src/schedule.rs | New scheduler module for executing sqllogictest steps |
| crates/sqllogictest/src/lib.rs | Exposed the new schedule module |
| crates/sqllogictest/src/engine/mod.rs | Refactored engine abstraction; introduced EngineRunner and updated enum |
| crates/sqllogictest/src/engine/datafusion.rs | Updated DataFusion engine to implement EngineRunner and adjusted new() |
| crates/sqllogictest/Cargo.toml | Added required dependencies (serde, tracing) |
Comments suppressed due to low confidence (1)
crates/sqllogictest/src/schedule.rs:35
- [nitpick] Consider renaming the field 'slt' to 'slt_file' in the Step struct to improve clarity regarding its purpose.
slt: String,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Introduce scheduler api for sqllogictests.
Are these changes tested?
UT.