MINOR: Remove unused code from storage classes #19853
Conversation
github-actions
bot
added
triage
|
@chia7712 PTAL |
| @@ -42,12 +42,6 @@ public void handleRemoteLogMetadata(RemoteLogMetadata remoteLogMetadata) { | |||
|
|
|||
| protected abstract void handleRemotePartitionDeleteMetadata(RemotePartitionDeleteMetadata remotePartitionDeleteMetadata); | |||
|
|
|||
| public void syncLogMetadataSnapshot(TopicIdPartition topicIdPartition, | |||
There was a problem hiding this comment.
KAFKA-16454 was filed to snapshot the __remote_log_metadata topic for faster restarts, so the syncLogMetadataSnapshot and RemoteLogSegmentMetadataSnapshot.java was not removed.
is it ok to remove it?
The unused syncLogMetadataSnapshot method can be removed.
| return config.getString(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP); | ||
| } | ||
|
|
||
| public String remoteLogMetadataManagerPrefix() { |
There was a problem hiding this comment.
we should not remove the "prefix" configs, they are used by the RemoteStorageManager and RemoteLogMetadataManger plugins.
There was a problem hiding this comment.
Restored the prefix configs.
There was a problem hiding this comment.
maybe we can add comments to avoid exceptional deletion down the line
There was a problem hiding this comment.
How about adding @SuppressWarnings("unused") to those unused methods or variables if we know they’re meant to be used elsewhere (or in the future)?
There was a problem hiding this comment.
That's a good idea.
Added @SuppressWarnings("unused") and comments.
return the prefix configs
address review comments
Remove unused code from storage classes.