-
Notifications
You must be signed in to change notification settings - Fork 936
kyuubi-sparksql support hive-udf permission control #7024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7024 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 694 696 +2
Lines 42768 43042 +274
Branches 5821 5858 +37
=======================================
- Misses 42768 43042 +274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FYI: You can run |
@turboFei please review thanks |
@liujinhui1994 any chance to supply a unit test to cover your changes, to avoid being broken accidentally in the future? |
udfExpr.nodeName.equals("HiveSimpleUDF") || | ||
udfExpr.nodeName.equals("HiveUDAFFunction") => | ||
val funName: String = getFieldValNoError(udfExpr, "name") | ||
val isFun: Boolean = getFieldValNoError(udfExpr, "isUDFDeterministic") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why should we check isUDFDeterministic
?
after a closer look at the code, the direction might be incorrect, there is an existing |
|
Why are the changes needed?
kyuubi-sparksql, supports UDF permission control
How was this patch tested?
We have already run it in production without any problems, and solved the problem of controlling the permissions used by our UDF.
Was this patch authored or co-authored using generative AI tooling?
NO