A way to disable the optimization for filling the stack traces #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
ppkarwasz
requested changes
Apr 25, 2025
There was a problem hiding this comment.
Thank you for your contribution!
I think that PrivateSecurityManagerStackTraceUtil should always be disabled on Android. Similarly to #3071 I would simply disable the class if the java.vendor system property contains Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #3639
This PR allows to disable the optimization for filling the stack traces on platforms where it is not available (e.g. on Android).
The developer of the port to such platform shall call
PrivateSecurityManagerStackTraceUtil.disable()before any loggins is printed, e.g. during the configuration phase.For this reason, the visibility of
PrivateSecurityManagerStackTraceUtilwas increased topublic.