Improve clang-format check step and update runner to Ubuntu 24.04 in CI workflow #3431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the GitHub Actions runner from ubuntu-latest to ubuntu-24.04 to ensure compatibility and consistency with the project environment.
szymon-czapracki
force-pushed
the
clang_compliance_fix
branch
2 times, most recently
from
6fccbc3 to
99a9334
Compare
sjanc
approved these changes
Jun 12, 2025
sjanc
reviewed
Jun 12, 2025
| exit 1 | ||
| echo "" | ||
| echo "For formatting guidelines, see:" | ||
| echo " $INFO_URL" |
There was a problem hiding this comment.
why 'exit 1' is removed? job should fail on style issues
There was a problem hiding this comment.
Fixup leftover, exit is now present - job is failing on style issues.
Use `bash` explicitly for the formatting check step for better shell compatibility Set bash +e setting so scripts won't exit on cmd non-zero status.
Add the `AlignConsecutiveMacros: true` option to the `.clang-format` file to improve readability and consistency of consecutive macro definitions. This change ensures that related macros are visually aligned, making the codebase easier to maintain and review.
If the job fails inform about coding standards.
szymon-czapracki
force-pushed
the
clang_compliance_fix
branch
from
99a9334 to
2df69df
Compare
sjanc
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the coding style check work-flow with the following improvements:
Changes the GitHub Actions runner from ubuntu-latest to ubuntu-24.04.
Explicitly sets bash as the shell for the clang-format check step.
Adds option to align consecutive macros.
These changes improve formatting issue detection and debugging during CI runs.