Skip to content

vue files - include parametric embedding support for javascript and styles #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Apr 7, 2025

This pull request will include updates for embedding support for vue files.

  • javscript

image

  • pug | jade

image

  • scss style language

image

  • less style language

image

For the moment, I didn't manage to include embedding for typescript.
The solution might not be that straightforward, as it doesn't have a standard lexer.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) CSS [ci] enable web job web [ci] enable web job labels Apr 7, 2025
@apache apache locked and limited conversation to collaborators Apr 7, 2025
@apache apache unlocked this conversation Apr 7, 2025
…de, less, sass

remove uncessary antlr lexer flags
update embeddng code test, update author comment
@haidubogdan haidubogdan force-pushed the t_javascript_vue_support_embedding_part branch from 90df33a to 525e741 Compare April 15, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS [ci] enable web job JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) web [ci] enable web job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants