-
Notifications
You must be signed in to change notification settings - Fork 235
Use correct header in Helm chart #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use correct header in Helm chart #1560
Conversation
@justinmclean as discussed on the incubator general mailing, this PR fixes the mistake on the header (the Helm chart yaml has been created in Apache Polaris (incubating)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jbonofre !
I disabled spotless in another PR because we have different headers to keep. Here the question is: this file has been created in Polaris. I guess yes but wanted to double check with you 😀 |
It was copied from Nessie. In this folder, the following files are copied from Nessie:
In general, I'd say around 70% of the Polaris Helm chart is a copy from Nessie Helm chart. |
@adutra ok, thanks, if it's copied from Nessie, this PR is not good because:
I'm updating the PR. Thanks ! |
f05a255
to
da0aa86
Compare
@adutra I compared Nessie and Polaris helm to find the files with more than 70% in common (same code). I updated the header and the |
da0aa86
to
237e157
Compare
Minor note, we should probably change the PR title to reflect we are restoring to Dremio now. |
237e157
to
aa44d99
Compare
@RussellSpitzer did it, thanks for the suggestion ! |
aa44d99
to
f50d153
Compare
The header doesn't seem correct here. It should be the ASF header as it's a Polaris resource.
@adutra can you please confirm ?