Remove unused module ContainerSpecHelper #1563
Open
+0
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
ebyhr,
HonahX and
pingtimeout
as code owners
snazy
requested changes
May 12, 2025
|
I don’t think it makes sense to create a standalone module just for a potential future persistence implementation. Even if this class is needed for NoSQL support, it should live within the NoSQL module itself, not in a separate module that adds unnecessary structure and overhead. Let’s keep the module boundaries meaningful and aligned with actual usage. |
|
Will it only be used by the NoSQL work? If not, maybe it can live outside the nosql module, but if so it should probably be contained there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't used anywhere in the project, plus it causes potential extra maintenance cost like #1562.