In binary distributions, now we group the artifacts and we add BSD/MIT licenses inline #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested review from
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei,
collado-mike and
snazy
as code owners
jbonofre
requested review from
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
HonahX,
singhpk234 and
pingtimeout
as code owners
|
I'm doing a new complete pass to double check all is there. @justinmclean do you mind to take a quick look ? Thanks ! |
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
previously approved these changes
May 13, 2025
jbonofre
force-pushed
the
license-inline
branch
3 times, most recently
from
22c321d to
bd2dba0
Compare
…T licenses inline
| Group: software.amazon.awssdk Name: sts Version: 2.31.30 | ||
| Group: software.amazon.awssdk Name: third-party-jackson-core Version: 2.31.30 | ||
| Group: software.amazon.awssdk Name: utils Version: 2.31.30 | ||
| Group: software.amazon.awssdk Name: apache-client Version: 2.31.40 |
There was a problem hiding this comment.
The version here changed, does that mean we missed an AWS bump in the notice?
There was a problem hiding this comment.
Yes, I ran my script again and I found that several versions in LICENSE and NOTICE were not up to date.
RussellSpitzer
approved these changes
May 14, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My script to help on
LICENSEdidn't include the required license content inline (for BSD or MIT licenses).I updated my script: