Eliminate usage of CatalogHandlers; introduce CatalogHandlerUtils #1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many methods in
IcebergCatalogHandler
(formerlyIcebergCatalogHandlerWrapper
) fall back to implementations inCatalogHandlers
, which sometimes can result in undesirable behavior. Two examples came up recently:CatalogHandlers
, surfacing the fact that there's a hardcoded 4 retries on every commitCatalogHandlers
To move us away from
CatalogHandlers
, this PR introduces a new classCatalogHandlerUtils
that's mostly a copy ofCatalogHandlers
as of Iceberg 1.8 and migrates usage ofCatalogHandlers
to this new type.Currently, the only meaningful change is that we inject a configuration store to make the number of retries on commit configurable.