[SPARK-51726][SQL] Use TableInfo for Stage CREATE/REPLACE/CREATE OR REPLACE table #50521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopj
force-pushed
the
replace
branch
2 times, most recently
from
f5d87e7 to
b3862da
Compare
HyukjinKwon
changed the title
aokolnychyi
approved these changes
Apr 10, 2025
| Transform[] partitions, | ||
| Map<String, String> properties) throws TableAlreadyExistsException, NoSuchNamespaceException { | ||
| return stageCreate(ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties); | ||
| default StagedTable stageCreate(Identifier ident, TableInfo tableInfo) |
There was a problem hiding this comment.
Optional: My personal preference would be to format it this way:
default StagedTable stageCreate(
Identifier ident,
TableInfo tableInfo) throws TableAlreadyExistsException, NoSuchNamespaceException {
...
}
| Transform[] partitions, | ||
| Map<String, String> properties) throws NoSuchNamespaceException, NoSuchTableException { | ||
| return stageReplace( | ||
| ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties); |
There was a problem hiding this comment.
Optional: What about putting each argument on a separate line?
There was a problem hiding this comment.
This seems consistent with existing code in this file
| Map<String, String> properties) throws NoSuchNamespaceException, NoSuchTableException { | ||
| return stageReplace( | ||
| ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties); | ||
| default StagedTable stageReplace(Identifier ident, TableInfo tableInfo) |
There was a problem hiding this comment.
Optional: Same comment about formatting as in create.
| Map<String, String> properties) throws NoSuchNamespaceException { | ||
| return stageCreateOrReplace( | ||
| ident, CatalogV2Util.v2ColumnsToStructType(columns), partitions, properties); | ||
| default StagedTable stageCreateOrReplace(Identifier ident, TableInfo tableInfo) |
There was a problem hiding this comment.
Here too, method + invocation.
gengliangwang
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of #50137 for the table replace methods in StagingTableCatalog.
Why are the changes needed?
To make it easier to add new parameters such as constraints.
Does this PR introduce any user-facing change?
Yes, but backwards compatible by providing a default implementation.
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No