[SPARK-51537][CONNECT][CORE][FOLLOW-UP][TEST] Add test to ensure Spark plugins are not reloaded #50526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vicennial @HyukjinKwon, Could you help review this PR, thx very much. |
|
Hi @HyukjinKwon, Could you please also take a look at it. Thx very much. |
|
Hi @HyukjinKwon, it would be great it you can help on this PR. Thx very much. |
HyukjinKwon
approved these changes
Apr 10, 2025
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 10, 2025
…k plugins are not reloaded ### What changes were proposed in this pull request? This PR adds a unit test to verify that Spark plugin JARs specified via `--jars` are not reloaded. ### Why are the changes needed? This PR is a followup of #50334 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The test added can pass ### Was this patch authored or co-authored using generative AI tooling? No Closes #50526 from wbo4958/SPARK-51537-followup. Authored-by: Bobby Wang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 622fa35) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 10, 2025
…k plugins are not reloaded ### What changes were proposed in this pull request? This PR adds a unit test to verify that Spark plugin JARs specified via `--jars` are not reloaded. ### Why are the changes needed? This PR is a followup of #50334 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The test added can pass ### Was this patch authored or co-authored using generative AI tooling? No Closes #50526 from wbo4958/SPARK-51537-followup. Authored-by: Bobby Wang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 622fa35) Signed-off-by: Hyukjin Kwon <[email protected]>
|
Merged to master, branch-4.0 and branch-3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a unit test to verify that Spark plugin JARs specified via
--jarsare not reloaded.Why are the changes needed?
This PR is a followup of #50334 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
The test added can pass
Was this patch authored or co-authored using generative AI tooling?
No