WW-5546 Fixes NPE when uploaded file is empty

[lukaszlenart]

WW-5546

[Copilot]

Pull Request Overview

This pull request addresses WW-5546 by introducing a fix for a NullPointerException when an uploaded file is empty. Key changes include:

• Adding a new static UploadedFile instance (NULL_CONTENT) in both FileUploadInterceptorTest and ActionFileUploadInterceptorTest.
• Adding new tests (testAcceptFileWithNoContent) to validate the behavior when the uploaded file has no content.
• Modifying AbstractFileUploadInterceptor to check for file content being null to avoid a NullPointerException.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
core/src/test/java/org/apache/struts2/interceptor/FileUploadInterceptorTest.java	Added NULL_CONTENT constant and a test case for file with no content
core/src/test/java/org/apache/struts2/interceptor/ActionFileUploadInterceptorTest.java	Added NULL_CONTENT constant and a test case for file with no content
core/src/main/java/org/apache/struts2/interceptor/AbstractFileUploadInterceptor.java	Updated null-check to also consider file.getContent()

Comments suppressed due to low confidence (2)

core/src/test/java/org/apache/struts2/interceptor/FileUploadInterceptorTest.java:256

• [nitpick] Consider renaming the boolean variable 'notOk' to something clearer such as 'isRejected' to improve readability.

boolean notOk = interceptor.acceptFile(validation, NULL_CONTENT, "filename.html", "text/plain", "inputName");

core/src/test/java/org/apache/struts2/interceptor/ActionFileUploadInterceptorTest.java:259

• [nitpick] Consider renaming the boolean variable 'notOk' to something clearer such as 'isRejected' for improved clarity in the test.

boolean notOk = interceptor.acceptFile(validation, NULL_CONTENT, "filename.html", "text/plain", "inputName");

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud