Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINKERPOP-3121 Prevent multiple by modulators or group count step #3089

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

andreachild
Copy link
Contributor

https://issues.apache.org/jira/browse/TINKERPOP-3121

Prevent multiple by operators from being used for the group count step by throwing IllegalStateException if modulateBy is called more than once.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.8-dev@c55d9cf). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.8-dev    #3089   +/-   ##
==========================================
  Coverage           ?   76.33%           
  Complexity         ?    14017           
==========================================
  Files              ?     1104           
  Lines              ?    69654           
  Branches           ?     7507           
==========================================
  Hits               ?    53170           
  Misses             ?    13745           
  Partials           ?     2739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andreachild andreachild changed the title TINKERPOP-3121 Prevent multiple by by modulators or group count step TINKERPOP-3121 Prevent multiple by modulators or group count step Apr 2, 2025
@kenhuuu
Copy link
Contributor

kenhuuu commented Apr 2, 2025

Missing CHANGELOG entry. Also consider adding new semantics into reference documentation and/or provider documentation.

@kenhuuu
Copy link
Contributor

kenhuuu commented Apr 2, 2025

VOTE +1

@andreachild andreachild force-pushed the TINKERPOP-3121-groupCount branch from 3989e50 to cab1655 Compare April 2, 2025 21:32
@andreachild
Copy link
Contributor Author

Missing CHANGELOG entry. Also consider adding new semantics into reference documentation and/or provider documentation.

Thanks for catching this, added changelog and upgrade documentation.

@vkagamlyk
Copy link
Contributor

VOTE+1

@Cole-Greer
Copy link
Contributor

VOTE +1

@Cole-Greer Cole-Greer merged commit bd9be2c into apache:3.8-dev Apr 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants