Skip to content

Cache the dynamic debug instances to avoid leaking them #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

fpavageau
Copy link
Contributor

This is due to debug-js/debug#678.

Fixes #174

@fpavageau fpavageau changed the title Cache the dynamic debug instances to avoir leaking them Cache the dynamic debug instances to avoid leaking them Apr 1, 2020
@fpavageau fpavageau force-pushed the fix-debug-memory-leak branch from a1b0d21 to c9e8709 Compare April 1, 2020 16:01
@keyurkarnik
Copy link
Collaborator

@fpavageau -
The fix for the memory leak looks good.
But you have added unrelated changes related to regex in your ESLint fix. Please remove them ASAP.
We are about to cut a release and cannot merge this PR because of that.

Copy link
Collaborator

@keyurkarnik keyurkarnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this commit from the PR, especially since you are making changes to the regex pattern.
This is unrelated to the memory leak issue

@fpavageau fpavageau force-pushed the fix-debug-memory-leak branch from c9e8709 to abf267c Compare April 15, 2020 08:39
@fpavageau
Copy link
Contributor Author

@keyurkarnik I've removed that commit from the branch as requested.

@keyurkarnik keyurkarnik merged commit 54f4e48 into apigee:master Apr 15, 2020
@fpavageau fpavageau deleted the fix-debug-memory-leak branch April 15, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak starting with version 3.0.12
2 participants