Add analysis for unresolved class/object properties; missing modifier 'local' #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
force-pushed
the
unresolved-property-analysis
branch
from
282cc86 to
a5f75ab
Compare
…ier 'local' This adds analysis for unresolved class/object properties. Additionally, it adds analysis for more members that are missing the 'local' modifier. As part of this change, the `ModuleMemberAnalyzer` is changed to simply `MemberAnalyzer`, because much of the logic can be shared between the two.
bioball
force-pushed
the
unresolved-property-analysis
branch
from
a5f75ab to
e23a232
Compare
stackoverflow
approved these changes
Apr 14, 2025
| val base = project.pklBaseModule | ||
| val context = module.containingFile.pklProject | ||
|
|
||
| val memberType: Type by lazy { |
There was a problem hiding this comment.
Why make it lazy when you are forcing it a few lines below?
There was a problem hiding this comment.
We only execute this if the node is PklObjectProperty or PklClassProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds analysis for unresolved class/object properties.
Additionally, it adds analysis for more members that are missing the 'local' modifier.
As part of this change, the
ModuleMemberAnalyzeris changed to simplyMemberAnalyzer, because much of the logic can be shared between the two.