Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoding of upcoming integrations from client codebase #40047

Open
NilanshBansal opened this issue Apr 3, 2025 · 0 comments
Open

Remove hardcoding of upcoming integrations from client codebase #40047

NilanshBansal opened this issue Apr 3, 2025 · 0 comments
Assignees
@AmanAgarwal041 @vivek-appsmith
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Task A simple Todo
Milestone
Config driven upc...

Comments

@NilanshBansal
Copy link
Contributor

NilanshBansal commented Apr 3, 2025 •
edited
Loading

Currently, the upcoming integrations and premium integrations are hardcoded in the client codebase to the first 4 integrations (Zendesk, salesforce, Slack, jira).
To make this scalable and also available to the users who are on an older AppSmith version we want these integrations to come from a config API driven, which is cloud services controlled, so in the cloud in the client codebase, we need to update this hardcoded logic to an API that the backend would provide.

Ref codebase:

appsmith/app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts

Line 9 in 1c17f35

const PREMIUM_INTEGRATIONS: PremiumIntegration[] = [

@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Apr 3, 2025
@NilanshBansal NilanshBansal mentioned this issue Apr 3, 2025
Closed
@NilanshBansal NilanshBansal changed the title Config driven upcoming integrations Remove hardcoding of upcoming integrations from client codebase Apr 3, 2025
@NilanshBansal NilanshBansal added Query & JS Pod Issues related to the query & JS Pod Integrations Product Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels Apr 3, 2025
@github-actions github-actions bot removed Query & JS Pod Issues related to the query & JS Pod labels Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanAgarwal041 AmanAgarwal041

@vivek-appsmith vivek-appsmith

Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Task A simple Todo
Projects
None yet
Milestone
Config driven upcoming integrations
Development

No branches or pull requests
4 participants
@Nikhil-Nandagopal @AmanAgarwal041 @NilanshBansal @vivek-appsmith