fix: Ensured no errors pops up when a space is given infront of export default

[prasad-madine]

Description

Currently, when creating a JS object, adding a space before export default {} throws an error. This behavior restricts developers from formatting their code according to their preferences. Allowing spaces before export default {} will enable more flexible and readable code formatting.

Fixes: [Bug]: Allow space before 'export default{}' #33984

Cypress video:

JS_Editor_spec2.js.mp4

Screenshots:

Before resolving bug:

After resolving bug:

Summary by CodeRabbit

• Bug Fixes

  • Improved JavaScript editor to accept leading spaces before the export default statement, enhancing code flexibility and reducing errors.

• Tests

  • Added a new Cypress test to verify the functionality of the JavaScript editor with the updated regex pattern.

---

PR Type

Bug fix

---

Description

• Updated the regular expression pattern in index.ts to allow spaces before export default statements.
• This change enables more flexible and readable code formatting by not throwing errors when spaces are present before export default.

[coderabbitai]

Walkthrough

This update introduces a Cypress test for a JavaScript editor bug, specifically addressing issues accommodating spaces before the export default statement. Additionally, it modifies the regular expression in the JS object evaluation logic to allow optional leading whitespace, ensuring smoother functionality and preventing related errors.

Changes

File	Change Summary
app/client/cypress/e2e/Regression/ClientSide/JSObject/JSObject_Editor_spec2.js	Added a Cypress test case to ensure the JavaScript editor handles spaces before export default.
app/client/src/workers/Evaluation/JSObject/index.ts	Updated the validJSBodyRegex to allow optional leading whitespace before the export default statement.

Possibly related issues

• appsmithorg/appsmith#33984: This PR addresses the issue by enabling spaces before the export default in JS objects.

Poem

In the code where exports gleam,
Spaces did the tests redeem,
A regex fix, both sharp and neat,
Makes our JavaScript complete.
Now the words can freely flow,
Thanks to changes we bestow.
🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fe0ccaa and 697b93b.

Files selected for processing (2)

• app/client/cypress/e2e/Regression/ClientSide/JSObject/JSObject_Editor_spec2.js (1 hunks)
• app/client/src/workers/Evaluation/JSObject/index.ts (1 hunks)

Additional comments not posted (2)

app/client/cypress/e2e/Regression/ClientSide/JSObject/JSObject_Editor_spec2.js (1)

1-26: Cypress test case looks good!

The test case correctly verifies that spaces before export default do not throw errors by creating a JS object and asserting the selection of a function.

app/client/src/workers/Evaluation/JSObject/index.ts (1)

66-66: Updated regular expression pattern looks good!

The updated regular expression pattern correctly allows spaces before export default statements.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[prasad-madine]

Hello @ApekshaBhosale , Could you please review this PR when you have sometime.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[prasad-madine]

Hi @ApekshaBhosale , Could you please review this PR??

[prasad-madine]

Hello @ApekshaBhosale @rohan-arthur , Could you please review this PR.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.